MNT: Appveyor no longer supported

[pllim]

As @astrofrog suggested in #462 (comment) .

Fix #454, close #393, close #350, close #346

Out of scope: Update outdated Travis instructions.

[bsipocz]

it's not just astropy any more, but a more broad range

[pllim]

Any suggested wording? 😸

[bsipocz]

I'm not picky on words, and was just nitpicking. In fact, lets get this merged now rather than have another CI round.
If we get bored, we can always come back and reword the readme here and possibly elsewhere, too, as it got written in a very organic way.

A more useful thing would be through to let the batchpr/issue bot loose on all the packages still using the ci-helpers appveyor, and let them know that things got evolved, they better evolve, too.

[bsipocz]

Thanks @pllim!

[astrofrog]

Thanks @pllim! Maybe it would be worth emailing astropy-dev as a heads up?

[pllim]

Thanks for the review, you two!

https://groups.google.com/g/astropy-dev/c/oP0OT3b0Jmk

[pllim]

Did a quick search and got 181 results. 😲

https://github.com/search?q=%22astropy%2Fci-helpers%22+in%3Afile+filename%3Aappveyor.yml

[pllim]

I opened issues to the repos I could find but sure I have missed some. Ah, well.

Getting the repo list was a bit tricky, as I couldn't get PyGithub, github3.py, or GitHub v4 GraphQL to work. This worked though (max is 100 per page, so needed 2 pages):

curl -o searchresults1.json -u user:token -H "Accept: application/vnd.github.v3+json" "https://api.github.com/search/code?q=\"astropy%2Fci-helpers\"+in%3Afile+filename%3Aappveyor.yml&page=1&per_page=100&sort=indexed&order=desc"

curl -o searchresults2.json -u user:token -H "Accept: application/vnd.github.v3+json" "https://api.github.com/search/code?q=\"astropy%2Fci-helpers\"+in%3Afile+filename%3Aappveyor.yml&page=2&per_page=100&sort=indexed&order=desc"

176 repos listed after removing a few duplicates.

168 repos left after ignoring forks and archived ones.

I did something like this (not the most polished but good enough for one-time use). Cannot trust the search results completely, so have to do additional checks.

from time import sleep

# flist is a list of Repository objects from PyGithub
# helper is the issue opener from batchpr

for repo in flist: 
    sleep(1) 
    try: 
        contents = repo.get_contents('appveyor.yml')   # Had to repeat this for .appveyor.yml, manually caught one Appveyor.yml
    except Exception as e: 
        print(repo.full_name, str(e)) 
        continue
    lines = contents.decoded_content.decode('utf-8').split('\n') 
    found = False 
    for line in lines: 
        if 'astropy/ci-helpers' in line and not line.startswith('#'): 
            found = True 
            break 
    if not found: 
        print(repo.full_name, 'no astropy/ci-helpers in file') 
        continue 
    print('*********', repo.full_name) 
    helper.run(repo.full_name)

[bsipocz]

Thank you @pllim! I have the feeling we had a solution to find these repos, but even if it's true it's certainly outdated by now.