-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test failures in halotools due to test runner incompatibility #17
Comments
Oops, missed that this issue exists - d62c292 may have fixed this... It's still failing but I think that's a real test failure rather than the testing system itself? |
Also, for background on the solution: the original problem stems from the fact that the test runner invoked by So that's super-convoluted why it failed, but the solution was basically just making sure that astropy is an up-to-date version when installed in travis. To avoid this sort of thing in the future, astropy could do a few things: there could be more checks in the test runner to work around added feature, conda could be updated to include other numpy versions (@embray or @astrofrog - was this intentional, or just an oversight?), or the test runner should be fully integrated with the helpers (see astropy/astropy-helpers#73 for other discussion on this last point). |
@eteq - we don't have control over conda versions of astropy, these are managed by the Continuum developers. They only build it with the latest Numpy version at the time. However, I've recently been investigating how to build conda packages and I've created a channel ( https://binstar.org/astrofrog/astropy/files You can install these with |
@astrofrog - ahh, gotcha - I thought we had been submitting some builds to them. Also, as @embray just mentioned in astropy/astropy-helpers#73, he anticipated exactly this issue in astropy/astropy#3019, but it accidentally didn't end up in master. So that should fix the problem directly, and then once thats in someone can update halotools' astropy_helpers to close this. |
Don't call out to git if we're sure it will fail
The package is failing the test suite when merging. This is a astropy problem with the versioning of pytest. @eteq is looking into this for us.
The text was updated successfully, but these errors were encountered: