Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igraph dependency bug #96

Closed
aphearin opened this issue Jul 13, 2015 · 12 comments
Closed

igraph dependency bug #96

aphearin opened this issue Jul 13, 2015 · 12 comments

Comments

@aphearin
Copy link
Contributor

@duncandc - not sure what the problem is yet, but I'm looking into it. Here's the summary:

test_igraph_functionality fails in my virtualenv. The traceback leads to the following:

      g = igraph.Graph(zip(sources, targets), n=matrix.shape[0], directed=directed,\
                            edge_attrs={'weight': weights},\
                            vertex_attrs={'x':x, 'y':y, 'z':z })

E AttributeError: 'module' object has no attribute 'Graph'

@duncandc
Copy link
Contributor

That is the very last function in groups.py I am not sure why that is causing an error. There are if statements that check to see if igraph is installed.

@aphearin
Copy link
Contributor Author

Yup, I see that. Looks like it should work as-written. I'm guessing this does not happen on your machine?

@duncandc
Copy link
Contributor

correct.

@aphearin
Copy link
Contributor Author

When I open up a python session, the version of igraph I have installed does not have a module named "Graph". Where did you get your version of igraph?

@duncandc
Copy link
Contributor

Well shit. This is annoying... there are two packages called igraph. https://pypi.python.org/pypi/igraph/0.1.8 and https://pypi.python.org/pypi/python-igraph/0.7.1.post6

The later is the appropriate one. I am not exactly sure what the former is...

@duncandc
Copy link
Contributor

maybe we should remove this module until we can clean it up?

@aphearin
Copy link
Contributor Author

What would need to be cleaned up besides this one issue?

@duncandc
Copy link
Contributor

Nothing. Either fix the check for igraph, or remove the igraph "feature"... Or remove groups.py from the repo....

@aphearin
Copy link
Contributor Author

I don't want to remove groups.py, this looks great.

Since there are two versions of igraph, we should probably make the igraph_available boolean written so that it knows how to distinguish between the two different packages. So for the short term, it just depends on how big of a pain figuring out that is relative to removing the igraph feature temporarily.

@duncandc
Copy link
Contributor

I could just throw in a "try: import igraph.Graph"

@aphearin
Copy link
Contributor Author

That's a fine (temporary) workaround.

@aphearin
Copy link
Contributor Author

I uninstalled igraph, ran the test suite, and everything passes. Then I reinstalled python-igraph, re-ran the test suite, and everything passes. So everything is entirely kosher. It's just that annoying problem of there being two versions of igraph floating around.

Let's just put this on the back-burner for now. At some point, we should decide on whether igraph should be added as a dependency.

eteq pushed a commit to eteq/halotools that referenced this issue Jul 15, 2015
Remove dependency on six and enable sphinx tests on Python 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants