You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
as mentioned in #99, unit tests are missing for the geometry package . Also check whether circular_overlap_grid is faster than elliptical_overlap_grid, if not then get rid of it. Checked, and it's indeed significantly faster.
Make the geometry APIs uniform.
The text was updated successfully, but these errors were encountered:
The APIs should now be uniform, but there is still a need for unit tests. We only need to test the circular_overlap_grid, elliptical_overlap_grid, and rectangular_overlap_grid functions
These tests should include a comparison to a reference result to make sure that rotation is properly dealt with (otherwise we could get the total area right, but the angle wrong).
Tests were added in #276, and the geometry module is about to be moved to the regions package. Any further issues or requests should be reported there.
as mentioned in #99, unit tests are missing for the geometry package .
Also check whetherChecked, and it's indeed significantly faster.circular_overlap_grid
is faster thanelliptical_overlap_grid
, if not then get rid of it.Make the geometry APIs uniform.
The text was updated successfully, but these errors were encountered: