Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write unit tests for geometry package #117

Closed
bsipocz opened this issue Jul 8, 2014 · 3 comments
Closed

write unit tests for geometry package #117

bsipocz opened this issue Jul 8, 2014 · 3 comments
Assignees
Labels

Comments

@bsipocz
Copy link
Member

bsipocz commented Jul 8, 2014

as mentioned in #99, unit tests are missing for the geometry package . Also check whether circular_overlap_grid is faster than elliptical_overlap_grid, if not then get rid of it. Checked, and it's indeed significantly faster.

Make the geometry APIs uniform.

@cdeil cdeil added the testing label Jul 11, 2014
@cdeil cdeil added this to the 0.1 milestone Jul 11, 2014
@astrofrog
Copy link
Member

The APIs should now be uniform, but there is still a need for unit tests. We only need to test the circular_overlap_grid, elliptical_overlap_grid, and rectangular_overlap_grid functions

@astrofrog
Copy link
Member

These tests should include a comparison to a reference result to make sure that rotation is properly dealt with (otherwise we could get the total area right, but the angle wrong).

@larrybradley larrybradley modified the milestones: 0.2, 0.1 Oct 24, 2014
@larrybradley larrybradley removed this from the 0.2 milestone Apr 29, 2015
@bsipocz
Copy link
Member Author

bsipocz commented Nov 11, 2016

Tests were added in #276, and the geometry module is about to be moved to the regions package. Any further issues or requests should be reported there.

@bsipocz bsipocz closed this as completed Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants