Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elliptical_overlap_grid generating nan's in some cases #277

Closed
tepickering opened this issue Jul 11, 2015 · 1 comment
Closed

elliptical_overlap_grid generating nan's in some cases #277

tepickering opened this issue Jul 11, 2015 · 1 comment

Comments

@tepickering
Copy link

When setting up regression tests for elliptical_overlap_grid, I ran into a number of failures where the masks were filled with nan. The ones I tracked down all had equal semi-major and semi-minor axis sizes. An example failure case is:

In [4]:
m = elliptical_overlap_grid(-1, 1, -1, 1, 1000, 1000, .8, .8, 0.5, 1, 10)
m.mean()
Out[4]:
nan

Slightly changing one of the axis values yields appropriate numbers:

In [13]:
m = elliptical_overlap_grid(-1, 1, -1, 1, 1000, 1000, .8, .80001, 0.5, 1, 10)
m.max()
Out[13]:
1.0000000000001465

Setting use_exact to 0 also yields correct results in all cases so the bug is somewhere within the use_exact code.

@bsipocz
Copy link
Member

bsipocz commented Aug 30, 2015

Closing as this was fixed in #276.

@bsipocz bsipocz closed this as completed Aug 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants