Addition of columns to photutils.isophote._isophote_list_to_table() #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems sensible that the gradient, and central values for the isophotes (with associated errors) should be included in the output table.
|
@ibusko, does this look OK to you to add these columns? |
|
@larrybradley yes, it sounds fine. I thought the gradient was already included, but if it's not there, it should be. It was in the old STSDAS version. The central value is also a good thing to have. Note that there is still some documentation to work on. At least, the docstrings should be updated wherever necessary. I also wonder if this affects the tutorial notebooks as well. |
larrybradley
approved these changes
Aug 5, 2019
|
Changelog added in 1526a4d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems sensible to include the intensity gradients and central values for the isophotes (with associated errors) in the created QTable.