-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pep8speaks.yml being ignored by bot? #944
Comments
Ops... maybe |
PR is merged, but I keep this open until we're sure it indeed worked. |
btw the 120 character is inherited from astroquery where we're much relaxed (due to the occasionally longer url strings), I would leave it to Larry to set the preferences here. |
FWIW, I am strongly opposed to a strict 80 char limit. But I could be talked down to 100 😉 |
hmm, well, it's up to Larry 🙊 |
Closing as it now indeed works, didn't complain about the 84 char long lines in #947 |
Phew! |
I admit I don't fully understand how pep8speaks picks its linter, but it seems to me like the pep8speaks.yml at the time of this writing (https://github.com/astropy/photutils/blob/c9a969df4df135ff67107632c2dac488a3a576b3/.pep8speaks.yml) is supposed to be setting the line length limit to 120. However in this issue, the bot was complaining about lines being too long that are 80-some characters:
![image](https://user-images.githubusercontent.com/346587/63114260-6e50cc80-bf62-11e9-8382-304da0284d12.png)
#745 (comment)
(since the bot updates its comments sometimes, here's a screenshot):
Is there maybe a misconfiguration of the bot or something? @bsipocz or @pllim have any idea?
The text was updated successfully, but these errors were encountered: