Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Update flake8 setting for pep8speaks #946

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Aug 15, 2019

Attempt to fix #944 . Not sure how to test.

Looking at https://github.com/OrkoHunter/pep8speaks/blob/master/.pep8speaks.yml , I am not sure why max-line-length is not working, so I copy over the one thing that appears missing here compared to that one.

@bsipocz
Copy link
Member

bsipocz commented Aug 15, 2019

Let's try this. Thanks @pllim!

@bsipocz bsipocz added this to the 0.8 milestone Aug 15, 2019
@bsipocz bsipocz merged commit 1ef56cc into astropy:master Aug 15, 2019
@bsipocz
Copy link
Member

bsipocz commented Aug 15, 2019

(no need to wait for CI, this has nothing to do with it)

@pllim pllim deleted the patch-1 branch August 15, 2019 18:28
@pllim
Copy link
Member Author

pllim commented Aug 15, 2019

I wonder if it is a pep8speaks bug like SublimeLinter/SublimeLinter-flake8#84 (though that issue is a year old). If this doesn't work out, I guess we can switch back to pycodestyle. Sorry for the trouble!

@bsipocz
Copy link
Member

bsipocz commented Aug 15, 2019

no worries, I'll ping the maintainer of it if it keeps misbehaving (he was very responsive in the past).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pep8speaks.yml being ignored by bot?
2 participants