Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make coveralls work #53

Merged
merged 1 commit into from
May 23, 2014
Merged

Make coveralls work #53

merged 1 commit into from
May 23, 2014

Conversation

cdeil
Copy link
Member

@cdeil cdeil commented May 21, 2014

@astrofrog As you can see here python setup.py test --coverage now works for photutils, but coverall tries to submit files for an Astropy coverage report instead of for photutils.

What configuration needs to be changed to make this work?

@cdeil cdeil added this to the 0.1 milestone May 19, 2014
@cdeil cdeil added the bug label May 19, 2014
@cdeil
Copy link
Member Author

cdeil commented May 21, 2014

Coveralls started to comment on photutils pull requests yesterday ... I don't know if we want this (I don't care either way).

But it still doesn't work ... latest example here shows that it's still trying to submit coverage reports for Astropy, not photutils files:
https://travis-ci.org/astropy/photutils/jobs/25633099#L617

$ if [[ $SETUP_CMD == 'test --coverage' ]]; then coveralls; fi
Submitting coverage to coveralls.io...
No source for /home/travis/home/travis/virtualenv/python2.7.6/lib/python2.7/site-packages/astropy/__init__
No source for /home/travis/home/travis/virtualenv/python2.7.6/lib/python2.7/site-packages/astropy/config/__init__
...

@astrofrog
Copy link
Member

I disabled the commenting. I'm going to take a look at this.

@astrofrog
Copy link
Member

@cdeil - I think this may have been fixed in the dev version of astropy. Can you make it so the coverage testing is done with the dev version of astropy?

@cdeil
Copy link
Member Author

cdeil commented May 21, 2014

@astrofrog Yes, submission to coveralls does work with the dev version of Astropy, thanks for the tip!

@cdeil cdeil changed the title coveralls doesn't work Make coveralls work May 21, 2014
@cdeil
Copy link
Member Author

cdeil commented May 22, 2014

@astrofrog I think this is ready ... can you have a look?

cdeil added a commit that referenced this pull request May 23, 2014
@cdeil cdeil merged commit 7cd57fd into astropy:master May 23, 2014
@cdeil cdeil deleted the issue_53 branch May 23, 2014 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants