Fix to IterativelySubtractedPSFPhotometry failing when Finder does not return None if no sources are detected #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eteq
requested changes
Nov 15, 2019
There was a problem hiding this comment.
I'm milestoning this for 0.7.2 since it's a bug fix, which then means the changelog needs to be moved. But perhaps @larrybradley can chime in to confirm he agrees it can go in 0.7.2 ?
…hich does not return None when no sources are detected would throw an error, failing to be caught by the while loop
Onoddil
force-pushed
the
psf_photometry_finder_none_fix
branch
from
1631aa9
to
74e27d6
Compare
|
Fair enough -- moved the changelog to |
eteq
approved these changes
Nov 15, 2019
larrybradley
pushed a commit
that referenced
this pull request
Dec 7, 2019
Fix to IterativelySubtractedPSFPhotometry failing when Finder does not return None if no sources are detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
_do_photometryloop ofIterativelySubtractedPSFPhotometryassumes that if no sources are detected then the returned variable will beNone. If a user provides a custom finder which instead returns an emptyTableobject, this won't be caught by the while loop and will error. This PR makes a simple fix to this, adding a check for a zero-length variable returned byself.finderin addition to aNonevariable.This PR blocks #740, which needs this PR merged before one of its tests will pass.