-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.2 #61
Comments
I've added a 1.2 milestone and I'm changing the title of this issue to "Release v1.2". |
I've gone through and assigned milestones to the issues. Here's what's currently under "v0.2" I think it could happen in a day or two. @leejjoon - Do you want to make the release or should I? |
OK, I'll make the release this week when the issues / PRs under https://github.com/astropy/pyregion/milestone/1 are done. @astrofrog - Can you please give me access to https://readthedocs.org/projects/pyregion/ so that I can add the stable version after the release? |
FYI: The "latest" build on readthedocs was from 2014. I just now started a new build: Looks like it worked just fine:
|
FYI: The readthedocs webhook wasn't activated, that's why docs builds hadn't triggered in the past years. I activated it just now for this repo here: https://github.com/astropy/pyregion/settings/hooks |
Is there a need for appveyor testing here? |
IMO yes, it would be great to have continuous testing on Windows to make sure everything's OK there. |
Adding Appveyor is done in #88. |
The v1.2 milestone is all-clear now: https://github.com/astropy/pyregion/milestone/1 |
I tried to follow http://docs.astropy.org/en/latest/development/affiliated-packages.html#releasing-an-affiliated-package and did this:
resulting in this error:
I see that
in https://github.com/astropy/pyregion/blob/master/MANIFEST.in#L10 @astrofrog @bsipocz - Any idea what the issue and fix is for this problem? |
When running from the git source folder, it works as it should:
https://gist.github.com/cdeil/cdd92c4cb5bde653fca0ede7ae4dd320#file-gistfile1-txt-L76 @bsipocz - Do you have time to add a travis-ci build that checks that tests from sdist pass, so that this keeps working going forward? |
I have no idea.
|
@bsipocz - Thanks for the tip. 😄 Changing to
fixes the issue. I have to go now, but I'll do the release tonight. |
@cdeil - Glad to hear it, I'm opening a PR for the template to fix this. Also in that this is fixed now with something unrelated to pyregion, I think no need to add the extra test to travis. |
Release sdist is here: https://pypi.python.org/pypi/pyregion/1.2 @astropy/regions-developers - Please try v1.2 and report any install issues or test fails here (if any). @bsipocz - Could you make the conda package? |
@ViviCoder wrote
My suggestion would be that you wait a few weeks for |
@astrofrog - Please add me ("deil") on RTD for pyregion, so that I can do admin stuff like adding v1.2. http://readthedocs.org/projects/pyregion/ |
@cdeil - Done once astropy/conda-channel-astropy#69 is merged. |
Just a note to self: to finish off the 1.2 release and close this issue, these things should happen first:
|
v1.2 docs are now available here: http://pyregion.readthedocs.io/en/1.2/ |
Closing this issue as the conda package is also done. |
@bsipocz - Thanks. Just to confirm: this works for me on OS X:
|
I am packaging pyregion for Debian.
The current version available on Pypi is quite old and does not contain the changes involving astropy.
Please consider releasing a new version of the package.
The text was updated successfully, but these errors were encountered: