Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another small writer fix #110

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Conversation

keflavich
Copy link
Contributor

From the commit:
another fix to the writer: the open function only accepts one argument. How
did this ever work?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.13% when pulling bc12dca on keflavich:another_writer_fix into 1ed4673 on astropy:master.

@cdeil cdeil self-assigned this Apr 17, 2017
@cdeil cdeil added the bug label Apr 17, 2017
@cdeil cdeil added this to the 2.0 milestone Apr 17, 2017
@cdeil
Copy link
Member

cdeil commented Apr 17, 2017

@keflavich - Thanks!
Merging this now.

I don't know if this was always broken or if a regression happened.
This is for the case of an empty shapelist, so probably very rarely executed by users.
And the whole write method as well as very large parts of pyregion/core.py are not covered by tests:
https://coveralls.io/builds/11110671/source?filename=pyregion%2Fcore.py#L160

Of course more tests would be important / welcome, see #44.

@cdeil cdeil merged commit 41779cc into astropy:master Apr 17, 2017
@cdeil cdeil mentioned this pull request Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants