Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UWS fails on missing version attribute #198

Closed
tomdonaldson opened this issue Dec 17, 2019 · 1 comment
Closed

UWS fails on missing version attribute #198

tomdonaldson opened this issue Dec 17, 2019 · 1 comment
Assignees
@tomdonaldson

Comments

@tomdonaldson
Copy link
Contributor

When reading a UWS response with a <job> element that has no version attribute, as can happen with asynchronous queries on some TAP services, this exception is raised:

AttributeError: 'LooseVersion' object has no attribute 'version'

Although that version attribute is required for UWS version 1.1 services, it remains optional for UWS v1.0 (see the UWS 1.1 specification section on versions). So if the UWS response is missing the version attribute, version 1.0 should be assumed.
@tomdonaldson tomdonaldson self-assigned this Dec 17, 2019
tomdonaldson added a commit to tomdonaldson/pyvo that referenced this issue Dec 17, 2019
@tomdonaldson
Add default for UWS version - Issue astropy#198
24ad36f
tomdonaldson added a commit to tomdonaldson/pyvo that referenced this issue Dec 17, 2019
@tomdonaldson
Add default for UWS version - Issue astropy#198
1286544 
Add changelog

Correct PR # in changelog

Fix flake8 errors

Style changes from review
tomdonaldson added a commit that referenced this issue Dec 17, 2019
@tomdonaldson
Merge pull request #199 from tomdonaldson/uws_default_version
ef3dd30 
Add default for UWS version - Issue #198
@tomdonaldson
Copy link
Contributor Author

Fixed with the merge of #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomdonaldson tomdonaldson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomdonaldson