Sia2 kwargs

[andamian]

#221

[cbanek]

LGTM!

[cbanek]

Guessing the build break is some kind of upstream future votable thing in astropy?

[tomdonaldson]

Guessing the build break is some kind of upstream future votable thing in astropy?

Yes, @cbanek . Surely this is due to astropy/astropy#9505, which will be released soon with astropy 4.1.

Whether these failures get fixed here to pass with both byte and str values, we should probably think about whether we have other coordination to do with respect to that change. I.e., which pyvo versions should pass testing with both astropy 4.0 and 4.1?

[codecov]

Codecov Report

Merging #222 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   72.20%   72.25%   +0.04%     
==========================================
  Files          42       42              
  Lines        4480     4488       +8     
==========================================
+ Hits         3235     3243       +8     
  Misses       1245     1245              

Impacted Files	Coverage Δ
pyvo/dal/sia2.py	70.98% <100.00%> (+0.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1567f...7205900. Read the comment docs.

[andamian]

All green now! @funbaker do you have time to take a look? Thanks

[andamian]

@funbaker - anything else needed for the approval?