Fixed wrong tox targets #260
Conversation
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 74.83% 74.83%
=======================================
Files 43 43
Lines 5035 5035
=======================================
Hits 3768 3768
Misses 1267 1267 Continue to review full report at Codecov.
|
| run: tox -e py${{ matrix.python-version }}-${{ matrix.astropy-version }} | ||
| run: | | ||
| # remove "." from matrix.python-version to get the defaults tox python versions | ||
| tox_python_target=$(echo py${{matrix.python-version}} | sed 's/\.//') |
There was a problem hiding this comment.
I think it is less confusing to set tox_python_target as another parameter for the matrix above, rather then doing some sed calls. This won't work if you want to inject other OS in the future.
There was a problem hiding this comment.
Not sure I understand what you mean. Add another dimension to the matrix and only run if python-version matches the tox_python_target?
There was a problem hiding this comment.
There is some package that enables explicit mapping of GH python version with the tox target but it doesn't seem worth it.
There was a problem hiding this comment.
I was thinking something like https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-including-additional-values-into-combinations but now that I look at it again, I realize maybe that's not what you want.
If this syntax works for you for now, I guess it is okay to deploy as is.
There was a problem hiding this comment.
It does the trick for now. If it breaks with future version then will address it at that time I guess. Thanks for your quick feedback!
#259