-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get wraps from functools instead of astropy #283
Conversation
Codecov Report
@@ Coverage Diff @@
## main #283 +/- ##
==========================================
- Coverage 75.51% 75.50% -0.01%
==========================================
Files 44 44
Lines 5129 5128 -1
==========================================
- Hits 3873 3872 -1
Misses 1256 1256
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is correct. Good catch!
Thanks for the quick review @pllim! |
We choke on this in astroquery CI, too. Would you care for a quick bugfix release? (The other option for me would be to change the pyvo version in the dev testing job to be dev, too, though that means that issues with the actual release may stay hidden until a new version of astropy comes out). |
@bsipocz I would go with a dev |
@astrofrog might release 5.0.1 next week. The To ease the |
Interesting. Thanks for pointing out those PRs (and doing one of them). I'm inclined to approve one of them, and go ahead and try it out with this bug fix release. Probably a release with only one thing in it is a good one to test with. |
CI broke against devastropy due to the
wraps
decorator being removed fromastropy.utils.decorators
as part of astropy/astropy#12625.It looks like that
wraps
was just a pass through fromfunctools
, so I changed the import to getwraps
directly fromfunctools
.