Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get wraps from functools instead of astropy #283

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

tomdonaldson
Copy link
Contributor

@tomdonaldson tomdonaldson commented Jan 5, 2022

CI broke against devastropy due to the wraps decorator being removed from astropy.utils.decorators as part of astropy/astropy#12625.

It looks like that wraps was just a pass through from functools, so I changed the import to get wraps directly from functools.

@tomdonaldson tomdonaldson added this to the v1.3 milestone Jan 5, 2022
@tomdonaldson tomdonaldson self-assigned this Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #283 (732f17a) into main (af59c9e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   75.51%   75.50%   -0.01%     
==========================================
  Files          44       44              
  Lines        5129     5128       -1     
==========================================
- Hits         3873     3872       -1     
  Misses       1256     1256              
Impacted Files Coverage Δ
pyvo/utils/decorators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af59c9e...732f17a. Read the comment docs.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct. Good catch!

@pllim pllim merged commit 94f792a into astropy:main Jan 5, 2022
@tomdonaldson
Copy link
Contributor Author

Thanks for the quick review @pllim!

@tomdonaldson tomdonaldson deleted the fix_ci_for_wraps branch January 5, 2022 16:11
@bsipocz
Copy link
Member

bsipocz commented Jan 7, 2022

We choke on this in astroquery CI, too. Would you care for a quick bugfix release? (The other option for me would be to change the pyvo version in the dev testing job to be dev, too, though that means that issues with the actual release may stay hidden until a new version of astropy comes out).

@andamian
Copy link
Contributor

andamian commented Jan 8, 2022

@bsipocz I would go with a dev pyvo version in testing. It just happened that this time the fix could be released earlier but that might not be necessarily the case all the time. The issue will stay hidden until the next astropy release at which point the CI will remind us that we need to release.

@pllim
Copy link
Member

pllim commented Jan 8, 2022

@astrofrog might release 5.0.1 next week. The wraps stuff will be in it.

To ease the pyvo release process, please consider one of these PRs:

@tomdonaldson
Copy link
Contributor Author

@astrofrog might release 5.0.1 next week. The wraps stuff will be in it.

To ease the pyvo release process, please consider one of these PRs:

Interesting. Thanks for pointing out those PRs (and doing one of them).

I'm inclined to approve one of them, and go ahead and try it out with this bug fix release. Probably a release with only one thing in it is a good one to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants