Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an appendix on real-world all-VO queries to the registry docs. #342

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

msdemlei
Copy link
Contributor

@msdemlei msdemlei commented Jun 9, 2022

This is an attempt to address
#289 (comment)

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #342 (8871833) into main (197cd38) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files          46       46           
  Lines        5493     5493           
=======================================
  Hits         4300     4300           
  Misses       1193     1193           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @msdemlei, this totally addresses my concern raised in #289.

@bsipocz bsipocz added this to the v1.4 milestone Jun 9, 2022
@andamian
Copy link
Contributor

andamian commented Jun 9, 2022

Yes, this looks good although it's just for interactive sessions. Are there any default timeouts in search for services that do not respond for some reasons or a mechanism to allow non-interactive sessions to avoid hangs?

@msdemlei
Copy link
Contributor Author

msdemlei commented Jun 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants