Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer formatting microseconds into SSA time literals #351

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

msdemlei
Copy link
Contributor

This started as an attempt to fix bug #350; it turns out it doesn't do that and the heasarc SSA has other problems. But SSA 1.1, sect. 4.1.1.4, essentially implies we shouldn't be producing microseconds, so by the golden rule of interoperability just let's not.

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #351 (4cc94ec) into main (ea07aed) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   78.28%   78.26%   -0.02%     
==========================================
  Files          46       46              
  Lines        5493     5494       +1     
==========================================
  Hits         4300     4300              
- Misses       1193     1194       +1     
Impacted Files Coverage Δ
pyvo/dal/ssa.py 55.75% <0.00%> (-0.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @msdemlei. This seems like a reasonable work around and looks good to me. The tests for SSA are a bit sparse, but that was a preexisting condition and seems out of scope for this minor change.

@tomdonaldson tomdonaldson merged commit 249114f into main Sep 18, 2022
@bsipocz bsipocz deleted the no-milliseconds-in-ssap branch January 24, 2023 19:32
@bsipocz bsipocz added this to the v1.4 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants