Changing registry/index.rst example to use short names. #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For one, this is the practice we show to people. And then, given this is now tested, we'd like to make the output stable, which it certainly is not if we use numeric indices -- the order of results is undefined in SQL.
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 78.36% 78.36%
=======================================
Files 46 46
Lines 5506 5506
=======================================
Hits 4315 4315
Misses 1191 1191 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For one, this is the practice we show to people. And then, given this is now tested, we'd like to make the output stable, which it certainly is not if we use numeric indices -- the order of results is undefined in SQL.
There are still some test failures in this branch; I argue they are unrelated to this change. One example, the get_tables one, also still fails, which is the consequence of a VizieR bug they'll soon fix.