MAINT: cleanup outer scope shadowing #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andamian
approved these changes
Feb 8, 2023
|
I went ahead with the merge as given the large number of files touched in this PR, I expect this may cause some conflicts with the other works (though all of those should be very trivial to resolve) |
|
Thanks for doing it! |
|
No worries, I'm just going through some prep stuff to ultimately make the SIA2 and cloud stuff work. |
bsipocz
added a commit
that referenced
this pull request
Mar 7, 2023
MAINT: cleanup outer scope shadowing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup redefining outer-scope variables. I've also added consistency in imports from astropy as some of them were causing these redefinitions.
There are still a few redefined-builtin cases, but fixing those would involve API modifications (as it involves arguments named e.g.
format,range,id)closes #390
(there is still a ~2000 line long pylint report, most of which are cosmetic, rather than functional suggestions, but some may touch real issues (e.g. pyvo/dal/tests/test_sia2_remote.py lists all attributes without any asserts, so those lines would trick tools like coverage to think the attributes are covered by tests).