Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: adding sys.version to User-Agent #452

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 29, 2023

Kind of a follow-up to #344

This potentially would help us to see when to drop python version support, etc.

The connecting astroquery PR is here: astropy/astroquery#2762

@bsipocz bsipocz added this to the v1.5 milestone Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #452 (16b490c) into main (c4f67e5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   80.08%   80.08%   -0.01%     
==========================================
  Files          52       52              
  Lines        6021     6020       -1     
==========================================
- Hits         4822     4821       -1     
  Misses       1199     1199              
Impacted Files Coverage Δ
pyvo/utils/http.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per RFC 7231 (or our VO digestion of it, https://ivoa.net/documents/Notes/softid/), this will make the python version and the OS a comment on pyVO. If that's what you want, I'll not stand in your way.

Me, I'd say the python system is a "product" in the sense of RFC 7231, and hence I'd slightly prefer having something like "pyVO/1.4 python/3.14 (linux)" as the UA string. Making the OS another product... ah, let's not overdo it.

@bsipocz
Copy link
Member Author

bsipocz commented Jun 30, 2023

Thanks for the approval. I have zero preference about the formatting, so I will change to your suggestion, it's less cryptic anyway than the current one.

@bsipocz bsipocz merged commit d6bbd36 into astropy:main Jul 6, 2023
10 of 11 checks passed
@bsipocz bsipocz deleted the enh_more_user_agent branch April 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants