Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: minor cleanup of old version workarounds #453

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 29, 2023

Trivial PR, but I didn't want to mix these changes into something totally unrelated.

@bsipocz bsipocz added this to the v1.4.2 milestone Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #453 (1efddf1) into main (c4f67e5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   80.08%   80.08%   -0.01%     
==========================================
  Files          52       52              
  Lines        6021     6020       -1     
==========================================
- Hits         4822     4821       -1     
  Misses       1199     1199              
Impacted Files Coverage Δ
pyvo/samp.py 34.09% <100.00%> (-1.47%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your call as to that anything that would break on these fallbacks would break on any number of other changes, too, so: go ahead.

@bsipocz
Copy link
Member Author

bsipocz commented Jun 30, 2023

Yeap, one of these is astropy 2.x-ish, the other is python 3.3, both well within out range. I checked and didn't find another similar and obvious case.

@bsipocz bsipocz merged commit ce0bd68 into astropy:main Jun 30, 2023
10 of 11 checks passed
bsipocz added a commit that referenced this pull request Aug 16, 2023
MAINT: minor cleanup of old version workarounds
@bsipocz bsipocz deleted the MAINT_minor_cleanup branch April 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants