Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: fix formatting raised by new flake8 version #468

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 1, 2023

This should fix the new errors we see due to the new flake8 release.
All of them seem to be reasonable, so we should just go ahead with the update.

@bsipocz bsipocz added this to the v1.4.2 milestone Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #468 (a5075ff) into main (4bb146a) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   79.98%   79.98%           
=======================================
  Files          52       52           
  Lines        6036     6036           
=======================================
  Hits         4828     4828           
  Misses       1208     1208           
Files Changed Coverage Δ
pyvo/dal/sia.py 62.19% <0.00%> (ø)
pyvo/dal/ssa.py 53.53% <0.00%> (ø)
pyvo/dal/mimetype.py 82.60% <100.00%> (ø)
pyvo/dal/query.py 84.81% <100.00%> (ø)
pyvo/dal/sia2.py 76.96% <100.00%> (ø)
pyvo/io/vosi/tests/test_capabilities.py 100.00% <100.00%> (ø)
pyvo/io/vosi/tests/test_tables.py 99.11% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks!

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patching this up!

@bsipocz bsipocz merged commit 074feb7 into astropy:main Aug 2, 2023
11 of 12 checks passed
@bsipocz bsipocz deleted the MAINT_fix_new_flake_issues branch August 2, 2023 16:42
bsipocz added a commit that referenced this pull request Aug 16, 2023
MAINT: fix formatting raised by new flake8 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants