DOC: fix DatalinkResults example #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alaity47 |
Codecov Report
@@ Coverage Diff @@
## main #475 +/- ##
==========================================
+ Coverage 80.00% 80.01% +0.01%
==========================================
Files 52 52
Lines 6035 6039 +4
==========================================
+ Hits 4828 4832 +4
Misses 1207 1207 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andamian
approved these changes
Sep 1, 2023
docs/dal/index.rst
Outdated
|
|
||
| >>> from pyvo.dal.adhoc import DatalinkResults | ||
| >>> # In this example you know the URL from somewhere | ||
| >>> url = 'https://ws.cadc-ccda.hia-iha.nrc-cnrc.gc.ca/caom2ops/datalink?runid=m4b2g3aos0fwmtmg&ID=ivo%3A%2F%2Fcadc.nrc.ca%2FHSTHLA%3Fhst_12477_28_acs_wfc_f606w_01%2Fhst_12477_28_acs_wfc_f606w_01_drz' |
There was a problem hiding this comment.
The runid parameter is not necessary here. It's used internally at the CADC to capture a session information which is not the case here.
|
RTD has been fixed in Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the example where a
DatalinkResultsinstance is created directly from a datalink url.