-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comparison to pyregion #123
Conversation
@joleroi - Thanks! I think it might be nice to have the result table (with some comments above or below summarising the table) in the docs (in some non-prominent page) to show status? What is the goal here, have 100% for all the files? Is that possible? Why doesn't pyregion achieve that? Or if you don't think the table belongs in the docs, just put the results table somewhere in the repo so that one can see it and link to it. (Github renders |
d10d533
to
719b08a
Compare
dev/regions_pyregion_comparison.py
Outdated
with open(str(filename)) as origin_file: | ||
for line in origin_file: | ||
if '(' in line: | ||
n_regions += 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be n_regions += line.count("(")
since there are some example files that have ;
-separated regions instead of newline-separated.
719b08a
to
f187710
Compare
f187710
to
10df935
Compare
@keflavich ok to merge? |
This PR adresses #45
It adds a script to compare speed and completeness of the DS9 region parsing to pyregion. It does not check correctness. This must be done manually for each region type, I guess though.
The result confirms what we already know. The regions package is far away from providing a complete DS9 support, but if it works it's much faster than pyregion.