Add Line{Circle|Sky}Region #129
Conversation
| """ | ||
|
|
||
| def __init__(self, start, end, meta=None, visual=None): | ||
| self.start = PixCoord._validate(start, name='start', expected='scalar') |
There was a problem hiding this comment.
Should there be a better way to instantiate PixCoords? It seems weird to use private methods (_validate) here
| """ | ||
| def __init__(self, start, end, meta=None, visual=None): | ||
| # TODO: test that start, end is a 0D SkyCoord | ||
| self.start = start |
There was a problem hiding this comment.
Should we merge without having the is_coord check? Or just add it?
There was a problem hiding this comment.
This (and also the PixCoord._validate issue) are unrelated to this PR - the same issue is present for all regions at the moment. So I would go for merging this and fixing the input validation separately.
| @property | ||
| def area(self): | ||
| """Region area (`~astropy.units.Quantity`)""" | ||
| return None |
regions/shapes/line.py
Outdated
| raise NotImplementedError() | ||
|
|
||
| else: | ||
| raise ValueError('mode should be one of local/affine/full') |
There was a problem hiding this comment.
it is not! All modes do the same.
|
@keflavich , others : Currently the line |
One step towards fixing #45