Fix 'text' renamed to 'label' #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
keflavich
changed the title
|
This is ready for review / merging once.... actually once nothing happens? I guess we need to merge #251 first, since I based this PR off that one |
|
Assuming this passes, will merge. |
cdeil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: do not merge.
In a previous commit, the metadata 'text' was renamed to 'label'. This breaks the one-to-one mapping between ds9 metadata keywords and astropy.regions metadata keywords, and therefore is a questionable decision. We need to determine, going forward, whether to:
Any feedback?