Implement compound regions #26
Conversation
|
This also changes the API as discussed in #25 |
|
I would merge this and add further functionality in future PRs. Comments? |
| @@ -29,16 +29,21 @@ class CompoundSkyRegion(SkyRegion): | |||
| Represents the logical combination of two regions in sky coordinates. | |||
| """ | |||
|
|
|||
| def __init__(self, region1, operator, region2): | |||
| def __init__(self, region1, region2, operator): | |||
There was a problem hiding this comment.
The reason I had operator in the center is because it makes it clearer how to deal with non-symmetric cases (e.g. region 1 without region 2)
There was a problem hiding this comment.
There was a bug (e.g. https://github.com/astropy/regions/blob/master/regions/core/core.py#L67) . It was just easier to change this line instead of all the others .. Do you need the operator in the middle?
There was a problem hiding this comment.
Ah I see - I personally think it would make it more readable, but up to you :)
There was a problem hiding this comment.
I'm more the RPN guy, you know 😉
|
@joleroi - that sounds fine. I have just one comment above at the moment. I think we will need some additional operators (for example the equivalent of |
|
Indeed, |
containsI don't know how to deal with
area,make_patchetc.