Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review #4

Closed
wants to merge 25 commits into from
Closed

Code review #4

wants to merge 25 commits into from

Conversation

astrofrog
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.28%) to 90.72% when pulling 7d72024 on master into d912f28 on no-code.

@cdeil
Copy link
Member

cdeil commented Nov 3, 2015

@astrofrog – FYI: @kingj90 and I started to add a gammapy.regions package to Gammapy today (see gammapy/gammapy@master...cdeil:regions#diff-a5281c6e0fa67c34613faf33bb32fef1R156 for a first version), because none of the existing packages (this regions package, photutils apertures or pyregion) really does what we need and work on pyregion is blocked by astropy/pyregion#54 .

This is mostly because we need to have something working for our use cases and merged by next week for PyGamma15. Hopefully gammapy.regions, pyregion and this regions package can be merged into one glorious regions package at some point.

@astrofrog astrofrog closed this Mar 23, 2016
@cdeil cdeil added this to the 0.1 milestone Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants