Fix DS9 IO of Text regions #548
Merged
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keflavich
approved these changes
Apr 9, 2024
|
For text regions, DS9 stores the text value the same way as additional metadata. It's not included in the shape definition (only the coords are). So for Text regions, we need to explicitly add "text" to the metadata when writing, and then remove it when reading (it gets stored in the class attribute) -- that prevents two copies of the same thing and them going out of sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where writing Text regions (e.g.,
TextPixelRegion) to DS9 would drop thetextfield. It also fixes an issue in the DS9 file reader/parser to have only one copy of thetextfield in the object instance (i.e., not duplicated inmeta).