Added 32-bit CircleCI configuration #78
Conversation
|
(I should rebase this once #71 is merged so that we can check if there are any issues with the Cython code) |
|
@astrofrog - do you think we should do this for photutils, too? |
|
@bsipocz - yes, though once there is a new version of regions out, we can immediately switch over photutils to use the Cython functions here to avoid duplication (even before we refactor photutils to use the region infrastructure) |
|
Turns out the 32-bit testing has already been useful to identify some corner cases! (feff1be) |
|
This should NOT be merged until #71 is merged, after which this should be rebased. |
| """ | ||
| In some of the geometrical functions, we have to take the sqrt of a number | ||
| and we know that the number should be >= 0. However, in some cases the | ||
| value is e.g. -1e-10, but we want to treat it as zero, which is what |
There was a problem hiding this comment.
Could we maybe make sure it's indeed close to zero and if not failing the code is OK.
There was a problem hiding this comment.
The issue is that then we have to then choose a threshold which will be architecture dependent. I would prefer to leave this as a function that we should call only if we are sure the result should be >= 0 modulo numerical uncertainty.
There was a problem hiding this comment.
I've just added a note about this though
Since we have Cython geometrical code, we should test this!