-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding python 3.6 to CI builds #96
Conversation
@bsipocz - Thanks! Indeed the Python 3.6 builds fail because Shapely isn't available yet. The Python 3.3 build is failing because wcsaxes isn't available: @bsipocz - I'm assigning this PR to you. Let us know when this is ready for final review. |
@cdeil - your suggestions sound good both for dropping 3.3 from the matrix and requiring astropy1.3. I'll come back to this PR in a few days to check whether shapely and mpl are available for python3.6. |
@bsipocz - Is it possible to finish up this PR now? Or are there still things missing for Python 3.6? (I'd like to make the regions 0.2 release now) |
@cdeil - I don't think there is any problem with python3.6, we already have a conda package for 0.1 for it with it. |
I think using conda-forge for those cases makes sense |
👍 |
…few superfluous builds
…d from allowed failures
d792b12
to
d5a2fe4
Compare
5444c66
to
a66e7e5
Compare
@cdeil - I'm having difficulties to make the python3.3 test pass, e.g. https://travis-ci.org/astropy/regions/jobs/201139597#L786 |
@bsipocz - Let's drop Python 3.3 for testing. (this issue already came up when you first made this PR and we agreed to drop it, see discussion above). |
Oops, sorry. I remember that comment, but misremembered that it was in this repo... |
I've moved this under the 0.2 milestone. |
@cdeil - Done. Coverage has dropped, I assume only because I haven't rebased this branch. |
@bsipocz - Thanks for this PR and all your work on CI ! |
Probably we need to wait a bit more until all the dependencies become available on python 3.6.
This PR also removes the dependency on standalone wcsaxes package, closing #104.