Ensure "empty" output pixels come out as 0, not nan, for "mean" moasic

astropy · Dec 8, 2023 · 31c4205 · 31c4205
1 parent e46fbd7
commit 31c4205
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/reproject/mosaicking/coadd.py b/reproject/mosaicking/coadd.py
@@ -276,6 +276,7 @@ def reproject_and_coadd(
         if combine_function == "mean":
             with np.errstate(invalid="ignore"):
                 output_array /= output_footprint
+                output_array[output_footprint == 0] = 0
 
     elif combine_function in ("first", "last", "min", "max"):
         for array in arrays:

diff --git a/reproject/mosaicking/tests/reference/test_coadd_solar_map.fits b/reproject/mosaicking/tests/reference/test_coadd_solar_map.fits
diff --git a/reproject/mosaicking/tests/test_coadd.py b/reproject/mosaicking/tests/test_coadd.py
@@ -236,11 +236,11 @@ def test_coadd_background_matching_one_array(self, reproject_function):
         np.testing.assert_allclose(array, array_matched)
         np.testing.assert_allclose(footprint, footprint_matched)
 
-    @pytest.mark.parametrize("combine_function", ["first", "last", "min", "max", "sum"])
+    @pytest.mark.parametrize("combine_function", ["first", "last", "min", "max", "sum", "mean"])
     @pytest.mark.parametrize("match_background", [True, False])
     def test_footprint_correct(self, reproject_function, combine_function, match_background):
         # Test that the output array is zero outside the returned footprint
-        # We're running this test over a somewhat large grid of paramters, so
+        # We're running this test over a somewhat large grid of parameters, so
         # cut down the array size to avoid increasing the total test runtime
         # too much.
         slice = np.s_[::3, ::3]