Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for APE 14 WCSes in find_optimal_celestial_wcs #334

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Jan 25, 2023

@pllim - could you try this out with GWCS instances?

Fix #328

@astrofrog astrofrog marked this pull request as ready for review January 26, 2023 15:32
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #334 (5525494) into main (06cab0d) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   93.58%   93.72%   +0.14%     
==========================================
  Files          24       24              
  Lines         717      733      +16     
==========================================
+ Hits          671      687      +16     
  Misses         46       46              
Impacted Files Coverage Δ
reproject/mosaicking/wcs_helpers.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that one comment on test class inheritance, LGTM. Thanks!

@pllim
Copy link
Member

pllim commented Jan 26, 2023

Once this is merged and released, please let me know the release number so I can pin over at spacetelescope/jdaviz#1949 . Thanks!

@astrofrog
Copy link
Member Author

@pllim - the next release is going to be a reasonably big one in terms of features etc so I need to go through and check everything is ok, it might be another week or two until a release. Hope that's ok! If you need this sooner you could always vendor the function temporarily?

@pllim
Copy link
Member

pllim commented Jan 26, 2023

Whoops maybe my suggestion broke the tests.

I think a couple of weeks is fine. Thanks!

@astrofrog
Copy link
Member Author

Ah yes there was a reason I had it that way - will remove the commit shortly!

@pllim
Copy link
Member

pllim commented Jan 26, 2023

Sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find_optimal_celestial_wcs does not accept GWCS
2 participants