Allow single inputs to find_optimal_celestial_wcs and add ability to specify HDU #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and add ability to pass in hdu_in for FITS files and HDULists
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
==========================================
- Coverage 92.62% 92.39% -0.23%
==========================================
Files 24 24
Lines 786 802 +16
==========================================
+ Hits 728 741 +13
- Misses 58 61 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
astrofrog
force-pushed
the
find_optimal_celestial_wcs_hdu
branch
from
49eb575
to
cb2729f
Compare
|
Once this is merged we can set up a similar fixture for output projections and add support for APE 14 shapes |
Cadair
reviewed
Mar 3, 2023
Comment on lines
+58
to
+59
| If only one input data needs to be provided, it is also possible to | ||
| pass it in without including it in an iterable. |
There was a problem hiding this comment.
Is the added complexity really worth this?
Cadair
approved these changes
Mar 3, 2023
| input_value = (array, wcs) | ||
| elif request.param == "nddata": | ||
| input_value = NDData(data=array, wcs=wcs) | ||
| elif request.param == "ape14_wcs": |
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still to do:
shape_outoptional if input WCS hasarray_shape#309)Fixes #323