Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for solar frames and non-degree units in find_optimal_celestial_wcs #360

Merged
merged 5 commits into from
May 19, 2023

Conversation

astrofrog
Copy link
Member

cc @Cadair

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #360 (5d1b682) into main (f95a92f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   92.36%   92.39%   +0.02%     
==========================================
  Files          24       24              
  Lines         825      828       +3     
==========================================
+ Hits          762      765       +3     
  Misses         63       63              
Impacted Files Coverage Δ
reproject/mosaicking/wcs_helpers.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@astrofrog astrofrog requested a review from Cadair May 18, 2023 13:26
@astrofrog astrofrog added the bug label May 18, 2023
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works!

@Cadair Cadair merged commit 639ac44 into astropy:main May 19, 2023
14 of 15 checks passed
@Cadair Cadair changed the title Fixes for solar frames and non-degree units Fixes for solar frames and non-degree units in find_optimal_celestial_wcs May 19, 2023
@Cadair Cadair changed the title Fixes for solar frames and non-degree units in find_optimal_celestial_wcs Fixes for solar frames and non-degree units in find_optimal_celestial_wcs May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants