Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new combine function to compute the minimum and maximum #369

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

fjankowsk
Copy link
Member

Hi,

I implemented a new combine function to compute the 2D maximum across the arrays/images to be mosaicked. It is helpful for PSF calculations, for instance.

It is a pretty straightforward addition.

Cheers.
Fabian

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #369 (8e3c6e7) into main (661963d) will increase coverage by 0.06%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   93.44%   93.51%   +0.06%     
==========================================
  Files          25       25              
  Lines         870      879       +9     
==========================================
+ Hits          813      822       +9     
  Misses         57       57              
Files Changed Coverage Δ
reproject/mosaicking/coadd.py 93.18% <94.11%> (+0.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@astrofrog
Copy link
Member

Thanks! I'll push some changes to resolve the conflicts and add 'min' as well, and add some tests.

fjankowsk and others added 2 commits September 7, 2023 11:46
… map over all co-added arrays. This is useful for PSF calculations, for instance.
@astrofrog astrofrog changed the title Added new combine function to compute the maximum Added new combine function to compute the minimum and maximum Sep 7, 2023
@astrofrog astrofrog merged commit 940983b into astropy:main Sep 7, 2023
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants