Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
Implements Cython's suggested performance fixes and removes the "performance hint" warnings. Looks like new behavior in Cython 3.0, to ensure proper handling if a Python exception is raised within a function. Since these subroutines don't call any Python code directly, no Python exception can be raised, so we can add
noexcept
flags and avoid Cython checking for an exception after every function call. These changes gain a bit of speed in a real-world benchmark, but it looks like just speed that we lost when changing to Cython 3.I also fixed a few warnings (removed an unused function, compiler worried about an uninitialized variable, explicitly set
language_level
to the new default, and added flag to not use the deprecated numpy api,) so nowdeforest.pyx
builds without any warnings on my computer.Performance of the adaptive code is indeed relevant to my interests---thanks for pointing this out, @astrofrog