Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ipython doc dependency #19

Merged
merged 3 commits into from May 1, 2017

Conversation

mirca
Copy link
Member

@mirca mirca commented Jan 4, 2017

Since #14 got merged, it looks like docs do not dependent on ipython anymore.
So, hopefully closes #16.

cc @nocturnalastro @bsipocz

@bsipocz
Copy link
Member

bsipocz commented Jan 4, 2017

@mirca - Looks good, though I wonder why you've skipped the doctest for some of the snippet lines?

@mirca
Copy link
Member Author

mirca commented Jan 4, 2017

@bsipocz Those lines which are skipped are tested under the plot directives. I've skipped some so that I don't need to repeat the whole code under plot. :)

@bsipocz
Copy link
Member

bsipocz commented Jan 4, 2017

I mentioned it only as leaving them untested gives a chance to diverge in future.
That said I have to admit that there are packages without running doctest on the narrative docs that I yet have to fix, figure out how to do better.

@mirca
Copy link
Member Author

mirca commented Apr 25, 2017

@nocturnalastro are you happy with these changes? ;)

@nocturnalastro
Copy link
Collaborator

@mirca, sorry I hadn't looked before.
Looks fine, as @bsipocz said we'll have to keep an eye on changes made to the docs to make sure that the plot and snippets are the same so we don't have to worry about testing the snippets.

@mirca
Copy link
Member Author

mirca commented Apr 27, 2017

@nocturnalastro sure!

@nocturnalastro nocturnalastro merged commit ed5ac93 into astropy:master May 1, 2017
@mirca mirca deleted the updata-doc-dependency branch May 1, 2017 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove doc dependency of ipython
3 participants