BUG: fix passing single Trace object to Background #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Background(image, trace, width) used to expect trace to be an iterable and interpret the trace as a list of floats, each representing a trace (and therefore raise an error about window overlaps). This syntax is now handled as expected.
kecnry
force-pushed
the
bg-single-trace
branch
from
f27ef86
to
86d501c
Compare
9 tasks
Merged
9 tasks
Codecov Report
@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 71.54% 71.63% +0.09%
==========================================
Files 9 9
Lines 629 631 +2
==========================================
+ Hits 450 452 +2
Misses 179 179
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ojustino
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background(image, trace, width)used to expecttraceto be an iterable and interpret it as a list of floats, each representing a trace (and therefore raise an error about window overlaps). This syntax is now handled as expected: as a single background window, equivalent toBackground(image, [trace], width).