-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created method to retrieve the wavelength lines from NIST. #30
Conversation
looks like pandas needs to be added to the travis dependency list...and BeautifulSoup... |
.rtd-environment.yml
Outdated
@@ -1,4 +1,4 @@ | |||
name: packagename | |||
name: dummy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use specreduce
here rather than dummy
Three tests still fail when trying to import |
@b1quint - If they are dependencies, the they should be added to the travis config file into the |
\o/ |
i'll restate my comment from #29 here: a disadvantage of returning DataFrames is the lack of any units metadata. pandas will likely not have any units support for a while as well (pandas-dev/pandas#15698). i think it's much more preferable to attach explicit units metadata to wavelengths than rely on a convention. this is why |
I think this package should use astroquery to access the NIST database rather than reinvent and implement the wheel. If any functionality is missing from astroquery, contribute it to there. |
i completely agree! had no idea NIST was already implemented in |
Not just NIST, but also a few other ones (that may not be relevant here, though): https://astroquery.readthedocs.io/en/latest/#other |
If this is the case, I will just close this Pull Request. Is that ok? |
Created method to handle what was requested on Issue #28.
This method uses BeautifulSoup4 instead of
HTMLParser
. It also uses NumPy and Pandas.