TST: Pin casa-formats-io in oldest-deps #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
job because it is upgrading numpy but we do not want that to happen.
Codecov Report
@@ Coverage Diff @@
## main #1093 +/- ##
=======================================
Coverage 70.73% 70.73%
=======================================
Files 64 64
Lines 4483 4483
=======================================
Hits 3171 3171
Misses 1312 1312 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
pllim
requested review from
eteq,
rosteen,
nmearl and
keflavich
as code owners
|
@astrofrog can you comment on casa-formats-io & numpy versioning? |
|
Will look soon! |
|
Introduced in radio-astro-tools/casa-formats-io#57 |
|
Maybe specutils needs to bump the minimum version of Numpy? Astropy core requires Numpy 1.22+. Requiring 1.21 in casa-formats-io seems reasonable. |
|
That is not my call to make. You can see in the Bumping required dependencies fall to specutils maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin casa-formats-io in oldest-deps job because it is upgrading numpy but we do not want that to happen.
Fix #1091