Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functions missing from __all__. #1097

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

weaverba137
Copy link
Member

This PR closes #1094, and adds a little bit more documentation to the docstring.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8707443) 70.73% compared to head (6e477ff) 70.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   70.73%   70.74%           
=======================================
  Files          64       64           
  Lines        4483     4484    +1     
=======================================
+ Hits         3171     3172    +1     
  Misses       1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. Would be nice to add an spPlate test as well that uses this, but that can be a separate follow-up (and you don't necessarily have to be the one to do it!)

@rosteen rosteen merged commit ba0ab68 into astropy:main Nov 15, 2023
11 checks passed
@rosteen rosteen mentioned this pull request Nov 15, 2023
rosteen pushed a commit to rosteen/specutils that referenced this pull request Nov 29, 2023
@weaverba137 weaverba137 deleted the add-spPlate branch December 1, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are SDSS spPlate readers "hidden" in the sdss.py loader?
2 participants