Separate out the codecov upload to a separate job in CI #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
=======================================
Coverage 86.82% 86.82%
=======================================
Files 63 63
Lines 4525 4525
=======================================
Hits 3929 3929
Misses 596 596 ☔ View full report in Codecov by Sentry. |
|
It works, merging. |
|
Over at OpenAstronomy/github-actions-workflows#199 , I found a bug in this setup where if we have two jobs that generate coverage, one will clobber the other. Since we only have one coverage job here, it doesn't matter. But if the situation change in the future, we can either switch to OpenAstronomy or I apply the same patch here. FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us see a test failure if the coverage upload fails. Thanks to @pllim for the example.