Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mixins #499

Closed
wants to merge 6 commits into from
Closed

Refactor mixins #499

wants to merge 6 commits into from

Conversation

nmearl
Copy link
Contributor

@nmearl nmearl commented Jul 31, 2019

This was referenced Aug 1, 2019
Open
Closed
@keflavich
Copy link
Contributor

spectral-cube still relies on having a FITS WCS object as SpectralCube.wcs for the other dimensions; for example, it uses things like the celestial convenience function. However, specutils requires that wcs have a with_spectral_unit method defined, which will happen once APE14 is completed. So, we need to wait on APE14.

Also, APE14 probably needs a .spectral method to complement the .celestial method, and maybe a .temporal and .polarizational too?

@nmearl nmearl marked this pull request as draft June 8, 2020 19:15
@nmearl nmearl changed the title [WIP] Refactor mixins Refactor mixins Jun 8, 2020
Base automatically changed from master to main March 22, 2021 15:52
@nmearl nmearl closed this Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eteq eteq Awaiting requested review from eteq eteq will be requested when the pull request is marked ready for review eteq is a code owner

@rosteen rosteen Awaiting requested review from rosteen rosteen will be requested when the pull request is marked ready for review rosteen is a code owner

@keflavich keflavich Awaiting requested review from keflavich keflavich will be requested when the pull request is marked ready for review keflavich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmearl @keflavich