Remove logging, handle test warnings, etc #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
changed the title
pllim
commented
Feb 10, 2022
|
|
||
|
|
||
| @pytest.fixture | ||
| def simulated_spectra(): |
There was a problem hiding this comment.
I moved the fixture here. This way, you don't have to import it and flake8 won't complain about the import.
pllim
commented
Feb 10, 2022
| pass | ||
|
|
||
|
|
||
| if sys.version_info < tuple((int(val) for val in __minimum_python_version__.split('.'))): |
There was a problem hiding this comment.
You don't need this. This is now defined in setup.cfg.
pllim
commented
Feb 10, 2022
| @@ -16,7 +15,7 @@ | |||
| from ..registers import data_loader | |||
| from ..parsing_utils import _fits_identify_by_name, read_fileobj_or_hdulist | |||
|
|
|||
| __all__ = ['spec_identify', 'spec_loader'] | |||
| __all__ = ['identify_pfs_spec', 'pfs_spec_loader'] | |||
There was a problem hiding this comment.
Not sure how this ever worked. This is a real bug.
pllim
commented
Feb 10, 2022
specutils/tests/test_analysis.py
Outdated
| @@ -87,19 +86,6 @@ def test_line_flux_masked(): | |||
| assert quantity_allclose(result.value, 720.61116, atol=0.001) | |||
|
|
|||
|
|
|||
| def test_line_flux_uncertainty(): | |||
* Move pytest fixture from tests/spectral_examples.py to conftest.py * Remove unused imports and check for that in tox.ini * Fix broken __all__ and check for that in tox.ini * Move flake8 setting from tox.ini to setup.cfg for consistent behavior between IDE and CI. Change list from select to ignore. Fix some. * Enable xfail_strict=true in testing. * Other minor clean-ups
rosteen
approved these changes
Feb 17, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes the following:
tests/spectral_examples.pytoconftest.pytox.ini__all__and check for that intox.iniflake8setting fromtox.initosetup.cfgfor consistent behavior between IDE and CI. Change list from select to ignore. Fix some.xfail_strict=truein testing.xref spacetelescope/jdaviz#1084