Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community favicon #8

Open
s-katte opened this issue Sep 25, 2020 · 8 comments
Open

Add community favicon #8

s-katte opened this issue Sep 25, 2020 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@s-katte
Copy link
Member

s-katte commented Sep 25, 2020

No description provided.

@gridhead gridhead changed the title Add Astrosonic logo to browser tab Add community favicon Sep 25, 2020
@gridhead gridhead added good first issue Good for newcomers hacktoberfest Contribute to the notion of open-source this October! labels Sep 25, 2020
@gridhead
Copy link
Member

Do comment under the issue for assignment. Once assigned, we would provide you with the image that you need to put as the website favicon.

@Mickey0001
Copy link

Easy-peasy I can do this no problem.

@gridhead
Copy link
Member

Cool. I am assigning this to you.

@gridhead
Copy link
Member

Here are the links of the favicons that we have been having a hard time to choose from.

Select anyone that you think would look the best and make it the favicon of the site.

@resparx
Copy link

resparx commented Sep 26, 2020

Hi @Mickey0001 i just fixed a duplicate issue of yours, I didn't notice that, there is an another issue like this. sry for that 🙏
If you are not fixing this , please let @t0xic0der know, so he would assign this to me.Thanks 😃

@gridhead
Copy link
Member

Hi @Mickey0001 i just fixed a duplicate issue of yours, I didn't notice that, there is an another issue like this. sry for that 🙏
If you are not fixing this , please let @t0xic0der know, so he would assign this to me.Thanks 😃

@resparx,

There are some points that I would like for you to note.

  • There was no duplicate of the given issue like you stated in your comment. Add fav icon to index.html file #13 (as I said before) is not an issue but a pull request that you made against issue Add community favicon #8 without asking for an assignment.
  • We would have appreciated if you would have accepted wholly that you jumped into making the changes, followed by a pull request without assignment and it would have been okay (considering how small the issue is).
  • But your inclination to bending facts into however you desire is disheartening to other participants and downright, offensive to the contributors of this humble project who take their time out to create and tag issues.

I would now have to state your pull request invalid as a corrective action to the comment you just made.

@resparx
Copy link

resparx commented Sep 26, 2020

Ok first of all, that was a miss from my side and i owe that. This is the first time where I've started to contribute, the issue which we are talking about was left un-resolved even after assigned to my fellow developer. Iam sorry for doing a work which is assigned to another one.

Thanks 🙂.

@gridhead
Copy link
Member

gridhead commented Nov 1, 2020

Any updates, @Mickey0001?

@gridhead gridhead removed the hacktoberfest Contribute to the notion of open-source this October! label Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants