Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change property to name for Twitter Cards #16

Closed
ben221199 opened this issue Sep 16, 2023 · 1 comment · Fixed by #19
Closed

Change property to name for Twitter Cards #16

ben221199 opened this issue Sep 16, 2023 · 1 comment · Fixed by #19
Labels
good first issue hacktoberfest-accepted 🎃 https://hacktoberfest.com help wanted

Comments

@ben221199
Copy link
Contributor

When generating the HTML for Twitter Cards, the meta tags have the attribute property instead of name. Twitter Cards use name, Open Graph uses property. See https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image for sample code.
@faizan1191 faizan1191 mentioned this issue Oct 2, 2023
Closed
@faizan1191
Copy link

@Gummibeer can you please check the PR which fixes this issue?
As I am new to open source suggestions and improvements will help me a lot.

@Gummibeer Gummibeer mentioned this issue Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest-accepted 🎃 https://hacktoberfest.com help wanted
Milestone
No milestone
3 participants
@Gummibeer @ben221199 @faizan1191