ROS1/ROS2 Hybrid: delphi_srr_msgs #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWhitleyWork
requested review from
Daniel-Stanek,
cvigna9,
rgunjala-as,
mlemm99,
cbradyas,
shan-as,
icolwell-as,
as-snehagn and
jilinzhouas
mlemm99
previously approved these changes
Nov 15, 2019
|
Sorry, @mlemm99 - Please review again. I forgot to add the BAG migration rules. |
mlemm99
previously approved these changes
Nov 15, 2019
Daniel-Stanek
previously approved these changes
Nov 15, 2019
JWhitleyWork
dismissed stale reviews from Daniel-Stanek and mlemm99
via
07af785
|
Looks like some conflicts need to be resolved. |
|
@icolwell-as - Conflicts resolved. It's hard to keep all of them conflict-free when I have to partition each package off when CI runs to get it to pass before all packages have been ported. |
Daniel-Stanek
previously approved these changes
Nov 18, 2019
mlemm99
previously approved these changes
Nov 18, 2019
icolwell-as
previously approved these changes
Nov 20, 2019
jilinzhouas
previously approved these changes
Nov 20, 2019
JWhitleyWork
dismissed stale reviews from jilinzhouas and icolwell-as
via
c8e7267
JWhitleyWork
dismissed stale reviews from mlemm99 and Daniel-Stanek
via
c8e7267
JWhitleyWork
force-pushed
the
maint/hybridize_delphi_srr
branch
from
24cce18
to
c8e7267
Compare
Daniel-Stanek
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second AutonomouStuff message package which is being hybridized to be able to be built in both ROS1 Kinetic/Melodic and ROS2 Dashing. CI on this branch is now running all 3 environments.
I've included at least one member from each engineering team to make sure that everyone has a chance to give feedback and we don't merge this until we're sure that nothing will break. After the following tasks are complete and I have an accepted review from each team, we will merge this in tandem with the changes to the other nodes that it effects. Here are the items that I know of (currently) that need to be completed before this can be merged:
If there are other items that need to be updated to coincide with this merge, please speak up and I'll add them to this list. Thanks!