Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bag migration rules cleanup #76

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Bag migration rules cleanup #76

merged 4 commits into from
Mar 12, 2021

Conversation

icolwell-as
Copy link
Member

Resolves #72 with the following changes:

  • Fix errors by adding install rules to the CMakeLists.txt file, so that migration rules are installed properly.
  • Consolidate individual message-specific rules into a single file with the package versions that the migrations apply to.
  • I wasn't able to resolve the warning cannot migrate from subtype [TrackMotionPower] to [TrackMotionPower], it seems like some kind of bug in the ROS code responsible for migrations. It's a warning regardless, so migrations are able to continue.

@icolwell-as icolwell-as merged commit f913f54 into master Mar 12, 2021
@icolwell-as icolwell-as deleted the 72_migration_rules_cleanup branch March 12, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvangeyn-as dvangeyn-as dvangeyn-as approved these changes

@jilinzhouas jilinzhouas jilinzhouas approved these changes

@shan-as shan-as Awaiting requested review from shan-as

@cbrown-as cbrown-as Awaiting requested review from cbrown-as

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delphi_srr_msgs throws errors when trying to run rosbag migration makerule.py
3 participants
@icolwell-as @dvangeyn-as @jilinzhouas